ndb_json performance tweaks. #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of obj methods. RegEx instead of loose date-string checks.
travisbeck
reviewed
Feb 3, 2017
gaek/ndb_json.py
Outdated
| ) | ||
|
|
||
|
|
||
| DATE_RE = re.compile(r'\d{4}[-/]\d{2}[-/]\d{2}') |
There was a problem hiding this comment.
This would probably be faster if you anchored it to the beginning of the line (with '^'). I assume that would be a reasonable thing to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to resolve #15
Add internal caching. Hardcode instead of compute. Functions instead of obj methods. RegEx instead of loose date-string checks.